[CI] Lock sonar scanner and mint versions and get rid of brew #3578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK Size
|
testableapple
force-pushed
the
ci/lock-sonar-version
branch
from
ef4ef59 to
959a4eb
Compare
testableapple
changed the title
|
testableapple
force-pushed
the
ci/lock-sonar-version
branch
from
365fd92 to
93c35d7
Compare
testableapple
force-pushed
the
ci/lock-sonar-version
branch
from
b519f2f to
7cc3563
Compare
laevandus
reviewed
Jan 31, 2025
| - name: Parse xcresult | ||
| if: failure() | ||
| run: | | ||
| brew install chargepoint/xcparse/xcparse |
There was a problem hiding this comment.
This one is still OK to install with homebrew, right? Asking because there was a comment above about homebrew.
There was a problem hiding this comment.
Yeah, this is used only when tests fail, which should be a rare case. But can't install it another way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥷 Problem
sonar-scannerandmintversions (even though we did, they were not locked on CI)developandmain📝 Summary
sonar-scannerandmintversionsbrewsonar-scanneris now installed via downloading an image directlymintis now installed viamintitselfLLC testaction to a separate workflow so the results can be published to SonarCloud on merges todevelopandmainas well as on PRs